Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[specfile] drop python-rpm dependency #3770

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

sandrobonazzola
Copy link
Contributor

rpm module is not being used by sos.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

rpm module is not being used by sos.

Signed-off-by: Sandro Bonazzola <[email protected]>
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3770
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle
Copy link
Member

This makes me wonder if there'd be a benefit to using the rpm module in conjunction with the RpmPackageManager abstraction we use, but that requires a much more thorough investigation as it would likely require us to do something similar for dpkg at the least, but that then gives us even more packaging dependencies at the end of that day. Writing that out, sounds like it's not worth it.

Ack.

@TurboTurtle TurboTurtle merged commit 9b59835 into sosreport:main Sep 2, 2024
36 checks passed
@sandrobonazzola sandrobonazzola deleted the drop_python_rpm branch September 3, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants