[sudo] Capture sudo and sudoers debug log files

[jcastill]

Capture sudo and sudoers debug log files.

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname [email protected]?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
• Are all passwords or private data gathered by this PR obfuscated?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3765
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[TurboTurtle]

for line in cfile: will iterate over the file without reading the entire thing into memory at once, and will automatically split on newlines.

[TurboTurtle]

log_files = ['/var/log/sudo_debug', '/var/log/sudoers_debug']
with open(config_file, 'r', encoding='UTF-8') as cfile:
    for line in cfile:
        if line.startswith('Debug'):
            log_files.append(line.split()[2])

if not self.get_option('all_logs'):
    self.add_copy_spec(log_files)
else:
    self.add_copy_spec([f"{log}*" for log in log_files]

We don't seem to actually care which file is for sudo or sudoers, as we are just passing the filepaths on regardless. With this we also get the other subsystems which are probably valuable if someone has gone through the effort of separating them out. And if the defaults don't exist, add_copy_spec() gracefully skips them.

With the above, we also don't spuriously split the line before we determine if we care about the line by it being started with the Debug keyword. Also, on my Fedora and RHEL boxes locally none of the config files use = as a delimiter, so not sure why we want to split on that?

[jcastill]

Nice, I'll make these changes.
Regarding the = that was an oversight on my side when copying from another plugin. Fixed in the next force push.

[arif-ali]

/packit rebuild-failed