Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bird, networking] Carry forward PR 1541 #3763

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

TurboTurtle
Copy link
Member

Two commits that first add the bird plugin and second add several devlink commands to the networking plugin, originally proposed in #1541, which seems to have been abandoned.

Commits have been updated to reflect modern sos/plugin design and current state of the networking plugin.

Closes #1541


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3763
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@jcastill jcastill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be some passwords stored in the config file. Inside bird.conf we have two examples:

#		password "hello" { algorithm hmac sha256; }; # Default is MD5
#	password "secret";	# Password used for MD5 authentication

First one is for protocol RIP, second one is for BGP. The format seems to be very similar if not the same, so it should be easy to obfuscate these lines.

Also I think the user can specify a log file instead of syslog, so it may be worth to check the config file for an entry with a pattern that starts like this:

log "filename"

@TurboTurtle
Copy link
Member Author

Interesting, the example config file I was looking at had no passwords but sure enough the upstream docs call that out.

Pushed a new set with an added postproc() and grabbing the log files called out in bird.conf.

TurboTurtle and others added 2 commits August 28, 2024 11:01
This commit carries forward the `bird` plugin from abandoned PR sosreport#1541
with modifications to align with the current layout and design of sos.

Co-authored-by: Alexander Petrovskiy <[email protected]>
Co-authored-by: Jake Hunsaker <[email protected]>
Signed-off-by: Jake Hunsaker <[email protected]>
This commit brings forward PR sosreport#1541, updated for the current design of
sos plugins, and ultimately adds several devlink commands for
collection.

Additionally included is some lingering fixups to f-strings.

Closes: sosreport#1541

Co-authored-by: Alexander Petrovskiy <[email protected]>
Co-authored-by: Jake Hunsaker <[email protected]>
Signed-off-by: Jake Hunsaker <[email protected]>
@TurboTurtle TurboTurtle merged commit 498ce94 into sosreport:main Sep 3, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants