-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ssh] Disable option 'userconfs' by default #3490
base: main
Are you sure you want to change the base?
Conversation
Having this option enabled by default can cause problems when users have their home directories on automount. Leave the option disabled by default so if needed we can enable it in the command line. Related: RHEL-22389 Signed-off-by: Jose Castillo <[email protected]>
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Personally, changing a default behaviour can give unexpected behaviour, especially if we're expecting it to be there. My hunch here is that we leave this as is. As it typically helps to debug wrong permissions in If we could tackle this in a different way, I would rather go in that direction. just my 2 cents on this |
On the other hand, I have seen a couple of cases where this has happened to customers in the last month. So there's that. We already have an unexpected behaviour because of having this enabled by default.
I'm open to any suggestions. |
We could change the default of the plugin opt to our standard |
I think this may work! Checking if home dirs are on autofs may be tricky, but I think I have an idea about how to do it. |
Just to clarify:
Let me know if I understood it wrongly. (I feel we are over-engineering the plugin option behaviour, tbh) |
Not exactly. |
Having this option enabled by default
can cause problems when users have their
home directories on automount. Leave the
option disabled by default so if needed
we can enable it in the command line.
Related: RHEL-22389
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines