-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microshift] add kube-apiserver log paths to microshift plugin #3357
[microshift] add kube-apiserver log paths to microshift plugin #3357
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
sos/report/plugins/microshift.py
Outdated
@@ -151,6 +151,8 @@ def setup(self): | |||
if self.path_exists('/var/lib/microshift-backups'): | |||
self.add_copy_spec(['/var/lib/microshift-backups/*/version', | |||
'/var/lib/microshift-backups/*.json']) | |||
if self.path_exists('/var/log/kube-apiserver'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do feel this check as a bit redundant; when this directory is not present, add_copy_spec
will detect no file to collect either way - just bit slower than via this explicit check (but if the dir exists, we do an extra check).
Usually, we dont have these checks, while we allowed it in this plugin without an objection, as it seems.
ACK for the current version as well as for plain unconditional add_copy_spec
one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I've removed the redundant check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition is fine, but we don't allow fixup commits for merges. Please squash this into a single commit (you'll need to repush the branch with --force), and then we'll be good to merge this.
do not perform redundant dir-exists check Signed-off-by: Jon Cope <[email protected]>
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines
Closes ushift-1631