Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microshift] add kube-apiserver log paths to microshift plugin #3357

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[microshift] add kube-apiserver log paths to microshift plugin #3357

merged 1 commit into from
Sep 19, 2023

Conversation

copejon
Copy link
Contributor

@copejon copejon commented Sep 15, 2023


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Closes ushift-1631

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3357
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@@ -151,6 +151,8 @@ def setup(self):
if self.path_exists('/var/lib/microshift-backups'):
self.add_copy_spec(['/var/lib/microshift-backups/*/version',
'/var/lib/microshift-backups/*.json'])
if self.path_exists('/var/log/kube-apiserver'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do feel this check as a bit redundant; when this directory is not present, add_copy_spec will detect no file to collect either way - just bit slower than via this explicit check (but if the dir exists, we do an extra check).

Usually, we dont have these checks, while we allowed it in this plugin without an objection, as it seems.

ACK for the current version as well as for plain unconditional add_copy_spec one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I've removed the redundant check.

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition is fine, but we don't allow fixup commits for merges. Please squash this into a single commit (you'll need to repush the branch with --force), and then we'll be good to merge this.

do not perform redundant dir-exists check

Signed-off-by: Jon Cope <[email protected]>
@TurboTurtle TurboTurtle merged commit 9e12fba into sosreport:main Sep 19, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants