Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hpssm] handle new names and higher slot positions #3342

Conversation

TrevorBenson
Copy link
Member

This change adds new non "Smart Array" labeled controllers to the pattern match for each slot and includes controllers now showing up in slots 10+.

It continues to honor older Smart Array Firmware which may report as HP instead of HPE.

Closes #3341

Signed-off-by: Trevor Benson [email protected]


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3342
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TrevorBenson
Copy link
Member Author

TrevorBenson commented Aug 25, 2023

Looking through Actions I don't see a failure listed for pull request event for this PR, or one for me as the actor.

@TurboTurtle Is the failed check something I need to address? I haven't looked very deep into the error itself, but suspect it may be a flaky run for the CI.

❗ Failed to start: Task java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@3cc8dfc5[Not completed, task = java.util.concurrent.Executors$RunnableAdapter@79394327[Wrapped task = TrustedListenableFutureTask@352251a7[status=PENDING, info=[task=[running=[NOT STARTED YET], com.google.api.gax.rpc.CheckingAttemptCallable@ffcdcfc]]]]] rejected from java.util.concurrent.ScheduledThreadPoolExecutor@f5b9300[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Restarted the failed CI job, nothing to do with this change.

@TurboTurtle TurboTurtle merged commit ca8fcd7 into sosreport:main Aug 28, 2023
34 checks passed
@TrevorBenson TrevorBenson deleted the tlb-hpssm-new-names-and-higher-range-slots branch December 15, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hpssm] controller collection misses Gen10+ controllers and above slot 9.
3 participants