[slurm] Add slurm plugin

[arif-ali]

Slurm is a workload manager in the HPC space, this is a start on this, and there may be further additions in the future

Resolves: #3329

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname [email protected]?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3329
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[pmoravec]

I think this test might not be needed. If a command isn't executable, sos won't store output of it (https://github.com/sosreport/sos/blob/main/sos/utilities.py#L261-L270) - but will add a record to manifest.json.

But definitely it is fine to use the test here.

[pmoravec]

Yeah, here the test makes a lot of sense :) (test executable once, save many "command not found" deadends ahead). :)

[arif-ali]

I tested it without the test, and the file was created, so hence added the tests.

# more sosreport-slurm-comp01-2023-08-08-ddtiwod/sos_commands/slurm/squeue_--all_--long
timeout: failed to run command ‘squeue’: No such file or directory

I could easily split the plugin out to multiple plugins, one for slurmd, slurmctld and slurmdbd, but pointless imho. It was easier to add everything in one rather than multiple plugins.

slurmd nodes (on their own) will never have the commands, but logs would be there, the commands are only on hosts that the server service is running, slurm or EL hosts, and slurm-client for Ubuntu.

Alternative method would have been to test for the above 2 packages for the command availability

[pmoravec]

I tested it without the test, and the file was created, so hence added the tests.

# more sosreport-slurm-comp01-2023-08-08-ddtiwod/sos_commands/slurm/squeue_--all_--long
timeout: failed to run command ‘squeue’: No such file or directory

I could easily split the plugin out to multiple plugins, one for slurmd, slurmctld and slurmdbd, but pointless imho. It was easier to add everything in one rather than multiple plugins.

slurmd nodes (on their own) will never have the commands, but logs would be there, the commands are only on hosts that the server service is running, slurm or EL hosts, and slurm-client for Ubuntu.

Alternative method would have been to test for the above 2 packages for the command availability

Ah I see, then the test makes a lot of sense on either place.

If there is more stuff to collect common than different, I would stay with one plugin.