Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugins/ubuntu] Do not load tls module if not loaded #3327

Merged
merged 1 commit into from
Aug 4, 2023
Merged

[plugins/ubuntu] Do not load tls module if not loaded #3327

merged 1 commit into from
Aug 4, 2023

Conversation

nkshirsagar
Copy link
Contributor

Adds a predicate to avoid loading the tls module if it is not loaded.

Resolves: #3326


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@nkshirsagar
Copy link
Contributor Author

Some testing,

# git checkout ubuntu_tls
branch 'ubuntu_tls' set up to track 'origin/ubuntu_tls'.
Switched to a new branch 'ubuntu_tls'
# git log
commit cbf7f652679e4af2914510082572732f03b316bf (HEAD -> ubuntu_tls, origin/ubuntu_tls)
Author: Nikhil Kshirsagar <[email protected]>
Date:   Fri Aug 4 18:22:53 2023 +0530

    [plugins/ubuntu] Do not load tls module if not loaded
    
    Adds a predicate to avoid loading the tls module if
    it is not loaded.
    
    Resolves: #3326
    
    Signed-off-by: Nikhil Kshirsagar <[email protected]>

commit 5caabe01086478c9f4fc175f02e2e2c7f89d080e (origin/main, origin/HEAD, main)
Author: Pavel Moravec <[email protected]>
Date:   Wed Aug 2 08:53:30 2023 +0200

    [discovery] Enable the plugin by containers
    
    Enable the plugin by running containers and collect some further system
    logs.
    
    Resolves: #3324
    
    Signed-off-by: Pavel Moravec <[email protected]>

commit 6d2334f1a942561f79eb4c855337156f2466185e
Author: Nikhil Kshirsagar <[email protected]>
Date:   Tue Jul 25 12:33:46 2023 +0530

    [plugins/ceph] Don't trigger ceph_common on cinder nodes
    
    ceph_common is triggered due to librados2 package. Remove it.
    
    Signed-off-by: Nikhil Kshirsagar <[email protected]>

home/nikhil/Downloads/sos/sos# bin/sos report -o ubuntu

sosreport (version 4.5.6)

This command will collect system configuration and diagnostic
information from this Ubuntu system.

For more information on Canonical visit:

        Community Website  : https://www.ubuntu.com/
        Commercial Support : https://www.canonical.com

The generated archive may contain data considered sensitive and its
content should be reviewed by the originating organization before being
passed to any third party.

No changes will be made to system configuration.


Press ENTER to continue, or CTRL-C to quit.

Optionally, please enter the case id that you are generating this report for []: 

 Setting up archive ...
 Setting up plugins ...
[plugin:ubuntu] skipped command 'ua status': required kmods missing: tls.   Use '--allow-system-changes' to enable collection.
[plugin:ubuntu] skipped command 'ua status --format json': required kmods missing: tls.   Use '--allow-system-changes' to enable collection.
 Running plugins. Please wait ...

  Starting 1/1   ubuntu          [Running: ubuntu]                                        
  Finished running plugins                                                               
Creating compressed archive...

Your sosreport has been generated and saved in:
	/tmp/sosreport-nikhil-XXX-08-04-odciddh.tar.xz

 Size	11.51KiB
 Owner	root
 sha256	3b39627055c170dfcd5b5771e287fefbf8dd9451cf1b8d19d5560e97a8ace354

Please send this file to your support representative.

# lsmod | grep tls
# 

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3327
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Adds a predicate to avoid loading the tls module if
it is not loaded.

Resolves: #3326

Signed-off-by: Nikhil Kshirsagar <[email protected]>
Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as per our discussions

@TurboTurtle TurboTurtle merged commit 2d3fc8f into sosreport:main Aug 4, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ubuntu plugin loads "tls" module
3 participants