Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foreman] - fetch id in foreman_auth_table #3323

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

snagoor
Copy link
Contributor

@snagoor snagoor commented Aug 1, 2023


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

Having an ID of the foreman_auth_table helps in sosreport will help to quickly identify the right auth source especially the LDAP auth provider source and provide further instructions to fetch data foreman-rake console for further troubleshooting.

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3323
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pmoravec
Copy link
Contributor

pmoravec commented Aug 1, 2023

ACK to the change itself (though the ID itself is useless until one knows details of a problematic user, if I am not mistaken - but it is trivial and no harm to collect this row).

DCO is failing on mail mismatch (see Summary in https://github.com/sosreport/sos/pull/3323/checks), plus please add "Resolves: #3323" or "Closes: #3323" to the commit message. Simple:

git commit --amend
git push --force

will apply the changes in commit message.

Signed-off-by: Nagoor Shaik <[email protected]>
Signed-off-by: Nagoor Shaik <[email protected]>
@snagoor
Copy link
Contributor Author

snagoor commented Aug 1, 2023

@pmoravec thanks for the review, I know its not a big issue. However, consider this scenario where there are multiple LDAP Auth Sources created (5 or more), we request the end user to provide us output of some rake commands per this https://access.redhat.com/solutions/2987201. In this case, having an ID would help us quickly build the commands that are of interest to us and not let the end user figure out the correct ID for this auth source and then provide us the required info.

@TurboTurtle TurboTurtle merged commit f62413b into sosreport:main Aug 1, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants