[microshift] Add initial support for backup info #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
TurboTurtle
reviewed
Jul 4, 2023
pacevedom
force-pushed
the
USHIFT-1226
branch
3 times, most recently
from
c1e1bb7
to
1601f41
Compare
dhellmann
reviewed
Jul 5, 2023
sos/report/plugins/microshift.py
Outdated
| self.add_forbidden_path('/var/lib/microshift') | ||
| if self.path_exists('/var/lib/microshift-backups'): | ||
| self.add_copy_spec(['/var/lib/microshift-backups/*/version', | ||
| '/var/lib/microshift-backups/health.json']) |
There was a problem hiding this comment.
I think @pmtk changed the name of this file.
There was a problem hiding this comment.
Done via glob for future proofness
TurboTurtle
approved these changes
Jul 5, 2023
Signed-off-by: Pablo Acevedo Montserrat <[email protected]>
|
I like the use of the wildcard, that will mean fewer updates here if we add more metadata files. This looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines