Skip to content

Commit

Permalink
[processor] Add a timeout to turbostat collection
Browse files Browse the repository at this point in the history
The `turbostat` command has been seen to hit the default 5-minute
timeout for reasons that are not immedately obvious. The behavior
pattern is that the `turbostat --debug sleep 10` command this plugin
captures may not exit until some form of input is received, at which
point the command "fails successfully" with the following message:

`turbostat: get_rapl_counters: failed to read perf_data (8 1): Success`

Prevent this condition from holding up sos report execution by adding a
timeout to this collection.

Resolves: #3753

Signed-off-by: Jake Hunsaker <[email protected]>
  • Loading branch information
TurboTurtle committed Aug 26, 2024
1 parent 8b0d86f commit 3d58e94
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion sos/report/plugins/processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,11 @@ def setup(self):
"cpupower frequency-info",
"cpupower info",
"cpupower idle-info",
"turbostat --debug sleep 10",
], cmd_as_tag=True, pred=cpupower_pred)

self.add_cmd_output("turbostat --debug sleep 10", cmd_as_tag=True,
pred=cpupower_pred, timeout=15)

if '86' in self.policy.get_arch():
self.add_cmd_output("x86info -a")

Expand Down

0 comments on commit 3d58e94

Please sign in to comment.