Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sidebar Active Link Highlighting by Adding Leading Slashes #315

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MohamadSafi
Copy link
Contributor

Summary

This pull request fixes the issue where the sidebar in the VitePress was not properly highlighting the active page. The root cause was identified as missing leading slashes in the link properties within the configuration file.

Changes

  • Added leading slashes (/) to all link paths in the sidebar configuration for consistency and proper routing.

Impact

  1. Ensures that the sidebar correctly highlights the active page when navigating through the documentation.
  2. It is important to fix the routing with leading slashes for future scaling, even if it wasn't just about the sidebar highlighting.
  3. Improveing navigation within the documentation, making it easier for users to know where they are and enhancing the overall reading experience.

Before and After

Below is a comparison showing the behavior before and after the fix:

Before Before

Testing

  • Verified that the sidebar now properly highlights the active page and the project builds with no issues.

Additional Notes

No other parts of the codebase were modified.

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
sora-docs ✅ Ready (Inspect) Visit Preview Nov 26, 2024 3:49pm

@MohamadSafi
Copy link
Contributor Author

Hi @stefashkaa Could you please check this PR.

@MohamadSafi
Copy link
Contributor Author

🤝 @WRRicht3r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants