Apk to jimple #888
Open
Apk to jimple #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sootup.core/src/main/java/sootup/core/inputlocation/FileType.java
# Conflicts: # sootup.java.bytecode/src/main/java/sootup/java/bytecode/inputlocation/PathBasedAnalysisInputLocation.java
# Conflicts: # sootup.core/src/main/java/sootup/core/jimple/basic/LocalGenerator.java # sootup.core/src/main/java/sootup/core/model/HasPosition.java # sootup.examples/src/test/java/sootup/examples/bodyInterceptor/BodyInterceptor.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/interceptors/CastAndReturnInlinerTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/interceptors/LocalSplitterTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/interceptors/typeresolving/AugEvalFunctionTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/interceptors/typeresolving/TypeResolverTest.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/JimpleSemanticsChecker.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/LocalSplitter.java
# Conflicts: # sootup.java.bytecode/src/test/java/sootup/java/bytecode/interceptors/typeresolving/BytecodeHierarchyTest.java # sootup.java.bytecode/src/test/java/sootup/java/bytecode/interceptors/typeresolving/TypeAssignerTest.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/AugEvalFunction.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/BytecodeHierarchy.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/PrimitiveHierarchy.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/TypePromotionVisitor.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/TypeResolver.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/types/TopType.java
# Conflicts: # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/AugEvalFunction.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/BytecodeHierarchy.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/PrimitiveHierarchy.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/TypePromotionVisitor.java # sootup.java.core/src/main/java/sootup/java/core/interceptors/typeresolving/types/TopType.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #888 +/- ##
=============================================
- Coverage 70.18% 67.58% -2.60%
- Complexity 4129 4131 +2
=============================================
Files 315 320 +5
Lines 15588 16198 +610
Branches 2672 2875 +203
=============================================
+ Hits 10940 10948 +8
- Misses 3761 4356 +595
- Partials 887 894 +7 ☔ View full report in Codecov by Sentry. |
swissiety
requested changes
Jul 12, 2024
| @Nullable | ||
| @Override | ||
| public SourceType getSourceType() { | ||
| return SourceType.Application; |
There was a problem hiding this comment.
in theory we have it configurable everywhere.. but I see no usecase to set it to Library - so i guess we can keep it that way.
| import sootup.core.model.Body; | ||
|
|
||
| /* Flow -insensitive def-use analysis */ | ||
| public class DexDefUseAnalysis { |
There was a problem hiding this comment.
is it dex specific or would it make sense to move it to the analysis module?
sootup.java.core/src/main/java/sootup/java/core/interceptors/Dex/DexNumberTranformer.java
Outdated
Show resolved
Hide resolved
sootup.java.core/src/main/java/sootup/java/core/interceptors/Dex/DexTransformer.java
Outdated
Show resolved
Hide resolved
| if (baseDef instanceof JAssignStmt) { | ||
| JAssignStmt stmt = (JAssignStmt) baseDef; | ||
| Value r = stmt.getRightOp(); | ||
| if (r instanceof JFieldRef) { |
There was a problem hiding this comment.
ValueVisitor would make sense here to replace the ifelse tree
1. Removed Tagged Instruction 2. Changed RTE to ISException 3. Resolved some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.