Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix F.clip_grad_by_norm in the case of small norm #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix F.clip_grad_by_norm in the case of small norm #201

wants to merge 1 commit into from

Conversation

takuseno
Copy link
Contributor

@takuseno takuseno commented Jan 11, 2020 •
edited
Loading

The operation of clip_by_norm must take the maximum value between the L2 norm and the clipping value.

See sony/nnabla#572 .

cc. @TE-AkioHayakawa

@takuseno takuseno mentioned this pull request Jan 16, 2020
Open
@takuseno
Copy link
Contributor Author

I've added some changes.

  • the unused kernel function has been removed
  • the backward function is corrected

@TE-AkioHayakawa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@takuseno