-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Apple Vision Pro #223
base: main
Are you sure you want to change the base?
Conversation
e08c2f4
to
615428b
Compare
xcrun simctl list devices vision | ||
system_profiler SPDeveloperToolsDataType | ||
xcodebuild -showsdks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking into this a bit, the current default xcode used on the macOS-14
runner is 15.0.1. The visionOS simulator requires xcode 15.2+ and I don't feel like adding in the logic to switch between xcode versions in this CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this still applies. I can either remove visionOS from the CI matrix or we can wait until the macos runner updates the default xcode. I'm not sure what the xcode versioning policy is (if there is one) on github runners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we do all the steps, including creating the simulator and deleting it, but making the steps that fail (presumably just lines 106 or 107) conditional:
if [ -z "${GITHUB_ACTIONS}" ]; then
# These steps fail in GitHub Actions due to https://...
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome. I didn't test it because I don't have a mac available to me right now. Some comments....
@@ -45,6 +45,9 @@ jobs: | |||
matrix: | |||
os: [ macOS-13, macOS-14 ] | |||
sim: [ tvOS, watchOS ] | |||
include: | |||
- os: macos-14 | |||
sim: visionOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you add here:
xcode_version: 15.2
then before you run the shell script you can add a step:
- if: ${{ matrix.xcode_version != '' }}
run: sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode_version }}.app
This is what I've done in my CI.
xcrun simctl list devices vision | ||
system_profiler SPDeveloperToolsDataType | ||
xcodebuild -showsdks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we do all the steps, including creating the simulator and deleting it, but making the steps that fail (presumably just lines 106 or 107) conditional:
if [ -z "${GITHUB_ACTIONS}" ]; then
# These steps fail in GitHub Actions due to https://...
fi
Apple Vision Pro support was added as a tier 3 target to rust in rust-lang/rust#121419 with
target_os
ofvisionos
.Depends on:
-Zbuild-std
flag foraarch64-apple-visionos
or the simulator target.