Preventing dynamic generation of BUFFER_PROFILE and BUFFER_PG entries in CONFIG_DB #3418
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Prevented buffermgrd from dynamically generating lossless BUFFER_PROFILE and BUFFER_PG entries based on port speeds and cable lengths that are configured on the switch.
Why I did it
The automatic generation of these entries can create an invalid config diff between the golden config and the running config.
How I verified it
Starting with a
config_db.jsonfile that did not containpg_lossless_*buffer profiles, I verified that after reloading the configuration withsudo config reload -y, these buffer profiles and their corresponding entries in the BUFFER_PG table were not automatically created in CONFIG_DB. Also, verified the same thing after doing a warm-reboot.Details if related
The dynamically-generated buffer profiles have the format
pg_lossless_<port_speed>_<cable_length>_profile. This PR prevents their creation and also the creation of corresponding BUFFER_PG entries.