Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACL] Add Tunnel Next Hop redirect support #3399

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Nov 27, 2024

What I did

  • Add support for Tunnel Next Hop as the Redirect Action in ACL Rules
  • Add a new Macro in the SAI mocking infra to clear extern mock_fns set
  • Add UT's

Why I did it

How I verified it

[----------] 4 tests from AclRedirectActionTest
[ RUN      ] AclRedirectActionTest.TunnelNH
[       OK ] AclRedirectActionTest.TunnelNH (10 ms)
[ RUN      ] AclRedirectActionTest.TunnelNH_ExistingNhObject
[       OK ] AclRedirectActionTest.TunnelNH_ExistingNhObject (10 ms)
[ RUN      ] AclRedirectActionTest.TunnelNH_InvalidTunnel
[       OK ] AclRedirectActionTest.TunnelNH_InvalidTunnel (10 ms)
[ RUN      ] AclRedirectActionTest.TunnelNH_InvalidNextHop
[       OK ] AclRedirectActionTest.TunnelNH_InvalidNextHop (10 ms)
[----------] 4 tests from AclRedirectActionTest (40 ms total)

Details if related

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Nov 28, 2024

[----------] 15 tests from MuxRollbackTest
[ RUN      ] MuxRollbackTest.StandbyToActiveNeighborAlreadyExists
[       OK ] MuxRollbackTest.StandbyToActiveNeighborAlreadyExists (86 ms)
[ RUN      ] MuxRollbackTest.ActiveToStandbyNeighborNotFound
pure virtual method called
terminate called without an active exception
FAIL tests (exit status: 134)

Unrelated UT failure. Not seen on local machine @lolyu Are you familiar on why this might fail?

@vivekrnv
Copy link
Contributor Author

[----------] 15 tests from MuxRollbackTest
[ RUN      ] MuxRollbackTest.StandbyToActiveNeighborAlreadyExists
[       OK ] MuxRollbackTest.StandbyToActiveNeighborAlreadyExists (86 ms)
[ RUN      ] MuxRollbackTest.ActiveToStandbyNeighborNotFound
pure virtual method called
terminate called without an active exception
FAIL tests (exit status: 134)

Unrelated UT failure. Not seen on local machine @lolyu Are you familiar on why this might fail?

NVM, interestingly only seen on bullseye environment. Fixed the problem

Signed-off-by: Vivek Reddy <[email protected]>
@prsunny
Copy link
Collaborator

prsunny commented Dec 3, 2024

@bingwang-ms for viz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants