Add diagnostic monitoring APIs for DOM, VDM and status access for CMIS modules #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S modules Signed-off-by: Mihir Patel <[email protected]>
|
@prgeor @qinchuanares Can you please help in reviewing this? |
| ======================================================================== | ||
| """ | ||
| vdm_real_value_dict = dict() | ||
| vdm_raw_dict = self.get_vdm(self.vdm.VDM_REAL_VALUE) |
There was a problem hiding this comment.
Shall we perform VDM 1) freeze 2) read and 3) unfreeze to update min/max/avg statistical values?
There was a problem hiding this comment.
@qinchuanares We plan to perform freeze and unfreeze operation at the caller side (from xcvrd).
@prgeor Please correct me if my understanding is incorrect.
There was a problem hiding this comment.
@mihirpat1 that is correct
prgeor
reviewed
Nov 14, 2024
prgeor
previously approved these changes
Nov 14, 2024
prgeor
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to add DOM, VDM and status related APIs to be inline with the changes proposed via the below HLD
HLD for diagnostic monitoring of CMIS based transceivers by mihirpat1 · Pull Request #1828 · sonic-net/SONiC (github.com)
Motivation and Context
a. get_transceiver_dom_flags
b. get_transceiver_vdm_real_value
c. get_transceiver_vdm_thresholds
d. get_transceiver_vdm_flags
e. get_transceiver_status_flags
How Has This Been Tested?
Tested the changes on the following types of transceivers
Additional Information (Optional)
MSFT ADO - 30215715