-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor parse_virtium_info to support new ssd model VTSM24ABXI160-BM110006 #495
Conversation
33f4ea7
to
05dadd1
Compare
Consider: Refactor this function so that: first check if current disk is one of the special Virtium SSD models, if so: parse attribute 231 directly and exit else (all other Virtium models) : check for presence of NAND endurance and Avg erase count in the output if present: get health that way What do you think? |
Virtirum ssd has two specical model which health need to be read from 231 rather than 'Remaining_Life_Left' Signed-off-by: Yuanzhe, Liu <[email protected]>
05dadd1
to
b9c9584
Compare
LGTM, I had rework the pr as you suggested, please help to review :-) |
@assrinivasan would you please review the new changes? |
Changes LGTM. @prgeor please help review/merge. Thanks! |
@prgeor kindly reminder to review |
Virtirum ssd has two specical model which health need to be read from 231 rather than 'Remaining_Life_Left' Signed-off-by: Yuanzhe, Liu <[email protected]>
Cherry-pick PR to 202405: #516 |
Virtirum ssd has two specical model which health need to be read from 231 rather than 'Remaining_Life_Left' Signed-off-by: Yuanzhe, Liu <[email protected]>
Description
The ID of "Remaining Life Left" attribute on 'Virtium VTSM24ABXI160-BM110006' device is 231.
However, it is not recognized by SmartCmd nor smartctl so far so we need to parse it using the ID number.
Also add a unit for this model
Motivation and Context
The Virtium prefix of the device model is shown from smartctl output, so keep it.
How Has This Been Tested?
unit test and real hardware test
show platform ssdhealth
Device Model : Virtium VTSM24ABXI160-BM110006
Health : 100.0%
Temperature : 52C
Additional Information (Optional)