[Credo][Ycable] Remove the thread locker protection from the thread-safe APIs #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afe APIs Signed-off-by: Xinyu <[email protected]>
vdahiya12
approved these changes
Aug 10, 2023
|
@vdahiya12 some issue in approving |
prgeor
approved these changes
Sep 21, 2023
|
@xinyulin could you update if tested with 202305 image? |
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 2, 2023
…afe APIs (#388) Signed-off-by: Xinyu <[email protected]> Co-authored-by: Prince George <[email protected]>
|
hi @yxieca please help merge into 202205. |
yxieca
pushed a commit
that referenced
this pull request
Dec 7, 2023
…afe APIs (#388) Signed-off-by: Xinyu <[email protected]> Co-authored-by: Prince George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix will remove the thread locker protection from thread-safe APIs. Thread lock is only needed on APIs that invoke the VSC.
Motivation and Context
To avoid the locker being occupied by APIs that don't need this protection. This fix can reduce the occurrence of the 'acquire locker timeout' exception.
How Has This Been Tested?
Tested on Arista-7050CX3-32S-C32