-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix testQosSaiDscpQueueMapping #15109
Conversation
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
/azp run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
@developfast @yanmo96 could you help to review? |
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the PR checker failure
Hi @vivekverma-arista, could you pls fix the PR checker failure? |
@vivekverma-arista I remember teamd has been disabled before the test. Why we still have lacp frames? |
What is the motivation for this PR? Regression introduced by sonic-net#14232 14232 06:34:12 __init__._fixture_generator_decorator L0088 ERROR | KeyError(8) Traceback (most recent call last): File "/data/tests/common/plugins/log_section_start/__init__.py", line 84, in _fixture_generator_decorator res = next(it) File "/data/tests/qos/qos_sai_base.py", line 2455, in tc_to_dscp_count for dscp, tc in dscp_to_tc_map.items(): KeyError: 8 How did you do it? Get rid of assumption of 8TCs from the code. How did you verify/test it? Ran the test on Arista 7260X3 platform.
What is the motivation for this PR? Regression introduced by sonic-net#14232 14232 06:34:12 __init__._fixture_generator_decorator L0088 ERROR | KeyError(8) Traceback (most recent call last): File "/data/tests/common/plugins/log_section_start/__init__.py", line 84, in _fixture_generator_decorator res = next(it) File "/data/tests/qos/qos_sai_base.py", line 2455, in tc_to_dscp_count for dscp, tc in dscp_to_tc_map.items(): KeyError: 8 How did you do it? Get rid of assumption of 8TCs from the code. How did you verify/test it? Ran the test on Arista 7260X3 platform.
What is the motivation for this PR? Regression introduced by sonic-net#14232 14232 06:34:12 __init__._fixture_generator_decorator L0088 ERROR | KeyError(8) Traceback (most recent call last): File "/data/tests/common/plugins/log_section_start/__init__.py", line 84, in _fixture_generator_decorator res = next(it) File "/data/tests/qos/qos_sai_base.py", line 2455, in tc_to_dscp_count for dscp, tc in dscp_to_tc_map.items(): KeyError: 8 How did you do it? Get rid of assumption of 8TCs from the code. How did you verify/test it? Ran the test on Arista 7260X3 platform.
Cherry-pick PR to 202405: #15725 |
What is the motivation for this PR? Regression introduced by #14232 14232 06:34:12 __init__._fixture_generator_decorator L0088 ERROR | KeyError(8) Traceback (most recent call last): File "/data/tests/common/plugins/log_section_start/__init__.py", line 84, in _fixture_generator_decorator res = next(it) File "/data/tests/qos/qos_sai_base.py", line 2455, in tc_to_dscp_count for dscp, tc in dscp_to_tc_map.items(): KeyError: 8 How did you do it? Get rid of assumption of 8TCs from the code. How did you verify/test it? Ran the test on Arista 7260X3 platform.
@vivekverma-arista PR conflicts with 202311 branch |
Description of PR
Summary:
Fixes #277
Type of change
Back port request
Approach
What is the motivation for this PR?
Regression introduced by #14232 14232
How did you do it?
Get rid of assumption of 8TCs from the code.
How did you verify/test it?
Ran the test on Arista 7260X3 platform.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation