Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testQosSaiDscpQueueMapping #15109

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

vivekverma-arista
Copy link
Contributor

@vivekverma-arista vivekverma-arista commented Oct 23, 2024

Description of PR

Summary:
Fixes #277

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Regression introduced by #14232 14232

06:34:12 __init__._fixture_generator_decorator    L0088 ERROR  | 
KeyError(8)
Traceback (most recent call last):
  File "/data/tests/common/plugins/log_section_start/__init__.py", line 84, in _fixture_generator_decorator
    res = next(it)
  File "/data/tests/qos/qos_sai_base.py", line 2455, in tc_to_dscp_count
    for dscp, tc in dscp_to_tc_map.items():
KeyError: 8

How did you do it?

Get rid of assumption of 8TCs from the code.

How did you verify/test it?

Ran the test on Arista 7260X3 platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/qos/qos_sai_base.py:2534:52: E231 missing whitespace after ','

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@StormLiangMS
Copy link
Collaborator

/azp run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StormLiangMS
Copy link
Collaborator

@developfast @yanmo96 could you help to review?

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/qos/qos_sai_base.py:2534:52: E231 missing whitespace after ','

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Copy link
Contributor

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the PR checker failure

@lolyu
Copy link
Contributor

lolyu commented Nov 12, 2024

Hi @vivekverma-arista, could you pls fix the PR checker failure?

@wangxin wangxin merged commit 75952db into sonic-net:master Nov 19, 2024
16 checks passed
@bingwang-ms
Copy link
Collaborator

@vivekverma-arista I remember teamd has been disabled before the test. Why we still have lacp frames?

sreejithsreekumaran pushed a commit to sreejithsreekumaran/sonic-mgmt that referenced this pull request Nov 20, 2024
What is the motivation for this PR?
Regression introduced by sonic-net#14232 14232

06:34:12 __init__._fixture_generator_decorator    L0088 ERROR  | 
KeyError(8)
Traceback (most recent call last):
  File "/data/tests/common/plugins/log_section_start/__init__.py", line 84, in _fixture_generator_decorator
    res = next(it)
  File "/data/tests/qos/qos_sai_base.py", line 2455, in tc_to_dscp_count
    for dscp, tc in dscp_to_tc_map.items():
KeyError: 8
How did you do it?
Get rid of assumption of 8TCs from the code.

How did you verify/test it?
Ran the test on Arista 7260X3 platform.
@vivekverma-arista vivekverma-arista deleted the qos-dscp-issue branch November 20, 2024 13:23
yutongzhang-microsoft pushed a commit to yutongzhang-microsoft/sonic-mgmt that referenced this pull request Nov 21, 2024
What is the motivation for this PR?
Regression introduced by sonic-net#14232 14232

06:34:12 __init__._fixture_generator_decorator    L0088 ERROR  | 
KeyError(8)
Traceback (most recent call last):
  File "/data/tests/common/plugins/log_section_start/__init__.py", line 84, in _fixture_generator_decorator
    res = next(it)
  File "/data/tests/qos/qos_sai_base.py", line 2455, in tc_to_dscp_count
    for dscp, tc in dscp_to_tc_map.items():
KeyError: 8
How did you do it?
Get rid of assumption of 8TCs from the code.

How did you verify/test it?
Ran the test on Arista 7260X3 platform.
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Nov 25, 2024
What is the motivation for this PR?
Regression introduced by sonic-net#14232 14232

06:34:12 __init__._fixture_generator_decorator    L0088 ERROR  | 
KeyError(8)
Traceback (most recent call last):
  File "/data/tests/common/plugins/log_section_start/__init__.py", line 84, in _fixture_generator_decorator
    res = next(it)
  File "/data/tests/qos/qos_sai_base.py", line 2455, in tc_to_dscp_count
    for dscp, tc in dscp_to_tc_map.items():
KeyError: 8
How did you do it?
Get rid of assumption of 8TCs from the code.

How did you verify/test it?
Ran the test on Arista 7260X3 platform.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15725

mssonicbld pushed a commit that referenced this pull request Nov 25, 2024
What is the motivation for this PR?
Regression introduced by #14232 14232

06:34:12 __init__._fixture_generator_decorator    L0088 ERROR  | 
KeyError(8)
Traceback (most recent call last):
  File "/data/tests/common/plugins/log_section_start/__init__.py", line 84, in _fixture_generator_decorator
    res = next(it)
  File "/data/tests/qos/qos_sai_base.py", line 2455, in tc_to_dscp_count
    for dscp, tc in dscp_to_tc_map.items():
KeyError: 8
How did you do it?
Get rid of assumption of 8TCs from the code.

How did you verify/test it?
Ran the test on Arista 7260X3 platform.
@mssonicbld
Copy link
Collaborator

@vivekverma-arista PR conflicts with 202311 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants