Add show subinterface test into PR checker. #13876
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolyu
approved these changes
Jul 30, 2024
lolyu
reviewed
Jul 30, 2024
| @@ -333,7 +335,6 @@ onboarding_t0: | |||
| - snmp/test_snmp_link_local.py | |||
| - snmp/test_snmp_psu.py | |||
| - snmp/test_snmp_queue_counters.py | |||
| - sub_port_interfaces/test_show_subinterface.py | |||
There was a problem hiding this comment.
We can remove it from onboarding T0 PR checker because it is added in T0 PR checker.
wangxin
approved these changes
Jul 31, 2024
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? In test script test_show_subinterface.py, we want to create the subinterfaces and check the status of these new created ports. While testing, we find that the new created ports will not inherit the speed of their ancestor, which is not expected. We suspect it is an image issue, so, we create an issue and use conditional mark to skip this case on vs testbed temporarily. As this case is skipped for now, we add it into PR checker, and after the issue is fixed, the case can run in PR test successfully. How did you do it? Create an issue, and use conditional mark to skip this case on vs testbed temporarily.
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? In test script test_show_subinterface.py, we want to create the subinterfaces and check the status of these new created ports. While testing, we find that the new created ports will not inherit the speed of their ancestor, which is not expected. We suspect it is an image issue, so, we create an issue and use conditional mark to skip this case on vs testbed temporarily. As this case is skipped for now, we add it into PR checker, and after the issue is fixed, the case can run in PR test successfully. How did you do it? Create an issue, and use conditional mark to skip this case on vs testbed temporarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In test script
test_show_subinterface.py, we want to create the subinterfaces and check the status of these new created ports. While testing, we find that the new created ports will not inherit the speed of their ancestor, which is not expected. We suspect it is an image issue, so, we create an issue and use conditional mark to skip this case on vs testbed temporarily. As this case is skipped for now, we add it into PR checker, and after the issue is fixed, the case can run in PR test successfully.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In test script
test_show_subinterface.py, we want to create the subinterfaces and check the status of these new created ports. While testing, we find that the new created ports will not inherit the speed of their ancestor, which is not expected. We suspect it is an image issue, so, we create an issue and use conditional mark to skip this case on vs testbed temporarily. As this case is skipped for now, we add it into PR checker, and after the issue is fixed, the case can run in PR test successfully.How did you do it?
Create an issue, and use conditional mark to skip this case on vs testbed temporarily.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation