Support for Memory Statistics Host-Services #167
Conversation
kanza-latif
changed the title
|
@qiluo-msft @prgeor @FengPan-Frank. Please help review our feature's hld and linked code PRs. |
tests/hostcfgd/test_vectors.py
Outdated
| "enabled": "true", | ||
| "retention_time": "15", | ||
| "sampling_interval": "5" | ||
| } |
There was a problem hiding this comment.
@FengPan-Frank , thank you for your feedback! I've adjusted the indentation for better readability. Please let me know if there are any other improvements needed.
scripts/hostcfgd
Outdated
| self.restart_memory_statistics() # Start or restart the daemon | ||
| else: | ||
| self.shutdown_memory_statistics() # Stop the daemon if disabled | ||
| else: |
There was a problem hiding this comment.
better to validate key strictly, otherwise any input not equals to "enable" will trigger reload.
There was a problem hiding this comment.
Thanks for your feedback, @FengPan-Frank . I've added stricter validation for configuration keys in the Memory_StatisticsCfg class to ensure only valid keys trigger updates. We'll also implement input checks in the command line utilities folder. Let me know if you have any further suggestions!
Signed-off-by: Arham-Nasir <[email protected]>
Signed-off-by: Arham-Nasir <[email protected]>
Signed-off-by: Arham-Nasir <[email protected]>
Signed-off-by: Arham-Nasir <[email protected]>
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft @xincunli-sonic @zbud-msft @FengPan-Frank Please help review the feature. |
Signed-off-by: Arham-Nasir <[email protected]>
Signed-off-by: Arham-Nasir <[email protected]>
|
@qiluo-msft @xincunli-sonic pls help review this feature |
|
/azpw run sonic-net.sonic-host-services |
Signed-off-by: Arham-Nasir <[email protected]>
Signed-off-by: Arham-Nasir <[email protected]>
Signed-off-by: Arham-Nasir <[email protected]>
Signed-off-by: Arham-Nasir <[email protected]>
|
Hi @FengPan-Frank , |
|
Please resolve conflict |
Signed-off-by: Arham-Nasir <[email protected]>
Hi @qiluo-msft |
|
/azpw run sonic-net.sonic-host-services |
Signed-off-by: Arham-Nasir <[email protected]>
Signed-off-by: Arham-Nasir <[email protected]>
|
Hi @qiluo-msft , Please assist us in merging this PR at your earliest convenience. Let me know if there are any additional actions needed from my side. Thank you! |
This PR provides hostservice demon functionality. It handles the configuration updates for the MemoryStatisticsd process, and listens to the ConfigDB changes and applies them by restarting, shutting down, or reloading the MemoryStatisticsd process.