[dockers/supervisord]: Don't use deprecated config options #20980
+1,172
−586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh352
force-pushed
the
bgp-supervisord-warnings
branch
2 times, most recently
from
6b73ac2 to
d25140f
Compare
|
/azpw ms_conflict |
Supervisord emits warnings due to the use of `stdout_logfile=syslog` and `stderr_logfile=syslog`. Replace with the modern configuration options of `stdout_syslog=true` and `stderr_syslog=true` and set the log file itself to `NONE` so it doesn't generate a file-based log. Warnings corrected look like: ``` 2024 Dec 1 15:31:06.467218 sw2 INFO pmon#supervisord 2024-12-01 15:31:04,033 WARN For [program:xcvrd], stderr_logfile=syslog but this is deprecated and will be removed. Use stderr_syslog=true to enable syslog instead. ``` Signed-off-by: Brad House (@bradh352)
bradh352
force-pushed
the
bgp-supervisord-warnings
branch
from
df36021 to
f53be3d
Compare
|
rebased to force rebuild to see if general sonic CI tests are working yet |
|
@lguohan any idea what this is blocked on ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Supervisord emits warnings due to the use of
stdout_logfile=syslogandstderr_logfile=syslog.Example:
Work item tracking
How I did it
Read the configuration documentation at https://github.com/Supervisor/supervisor/blob/main/docs/configuration.rst
Then replaced with the modern configuration options of
stdout_syslog=trueandstderr_syslog=trueand set the log file itself toNONEso it doesn't generate a file-based log.How to verify it
Apply patch, observe the warnings go away in syslog.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
master as of 20241201
Description for the changelog
[dockers/supervisord]: Don't use deprecated config options
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Brad House (@bradh352)