gNOI Cold Reboot - Integrated Rebootbackend changes #20710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdwhdw
suggested changes
Nov 7, 2024
rkavitha-hcl
force-pushed
the
gnoi_cr_PR2
branch
2 times, most recently
from
5ac7797 to
c4b69a6
Compare
hdwhdw
approved these changes
Nov 20, 2024
Comment on lines
161
to
193
| void reboot_thread(void); | ||
| void do_reboot(void); | ||
| Progress send_dbus_reboot_request(); | ||
| void do_cold_reboot(swss::Select &s); | ||
|
|
||
| // Inner loop select handler to wait for platform reboot. | ||
| // wait for timeout | ||
| // wait for a stop request (sigterm) | ||
| // Returns: | ||
| // EXIT_EARLY: an issue occurred that stops WARM | ||
| // PROCEED: if reboot timeout expired | ||
| Progress platform_reboot_select(swss::Select &s, | ||
| swss::SelectableTimer &l_timer); | ||
|
|
||
| // Wait for platform to reboot while waiting for possible stop | ||
| // Returns: | ||
| // EXIT_EARLY: an issue occurred that stops WARM | ||
| // PROCEED: if reboot timeout expired | ||
| Progress wait_for_platform_reboot(swss::Select &s); | ||
|
|
||
| // Log error string, set status to RebootStatus_Status_STATUS_FAILURE | ||
| // Set status message to error_string. | ||
| void log_error_and_set_non_retry_failure(const std::string error_string); | ||
|
|
||
| // Log error string, set status to | ||
| // RebootStatus_Status_STATUS_RETRIABLE_FAILURE Set status message to | ||
| // error_string. | ||
| void log_error_and_set_failure_as_retriable(const std::string error_string); | ||
|
|
||
|
|
||
| // Request is input only. | ||
| // Response is ouput only. | ||
| // Return true if preconditions met, false otherwise. | ||
| bool check_start_preconditions(const gnoi::system::RebootRequest &request, | ||
| NotificationResponse &response); |
There was a problem hiding this comment.
Nits: suggest stay consistent by staying pascal case and only use snake case for getters and setters.
rkavitha-hcl
force-pushed
the
gnoi_cr_PR2
branch
from
c4b69a6 to
f6fcecd
Compare
rkavitha-hcl
force-pushed
the
gnoi_cr_PR2
branch
3 times, most recently
from
4b8a987 to
76fa407
Compare
rkavitha-hcl
force-pushed
the
gnoi_cr_PR2
branch
from
76fa407 to
018b775
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)