Added package to compile and link yaml parser in C++ #20698
Conversation
Signed-off-by: Abhishek Dosi <[email protected]>
|
@saiarcot895 : can you please help in review this. |
dockers/docker-fpm-frr/Dockerfile.j2
Outdated
| @@ -16,6 +16,7 @@ RUN apt-get update && \ | |||
| libc-ares2 \ | |||
| iproute2 \ | |||
| logrotate \ | |||
| libyaml-cpp-dev \ | |||
There was a problem hiding this comment.
Assuming you don't actually need the development headers at runtime, there shouldn't be any changes needed in this file. Dependency resolution should be able to install the runtime library automatically.
There was a problem hiding this comment.
@saiarcot895 : not sure if i completely follow this comment. Without this change I was getting run-time error when fpmsyncd was running in bgp docker. PR for reference: sonic-net/sonic-swss#3353
There was a problem hiding this comment.
thanks @saiarcot895 , i have removed the change. Yes, as part of the build of docker-swss-layer-bookworm.gz all swss dependency are resolved and we don't need to explicit install on in frr docker.
|
@saiarcot895 : can we get signoff on this, |
|
/azpw ms_conflict |
2 similar comments
|
/azpw ms_conflict |
|
/azpw ms_conflict |
|
'/azpw ms_conflict' |
|
/azpw ms_conflict |
1 similar comment
|
/azpw ms_conflict |
|
@rlhui : can you help merge this. |
|
@yejianquan for 202405 branch |
yejianquan
added
Request for 202405 Branch
and removed
Cherry Pick Conflict_202405
Request for 202405 Branch
labels
|
Having conflict @abdosi , please create a seperate PR to 202405 and add to wishlist |
@yejianquan : PR for 202405: #20856 |
What I did:
Added package to compile and link yaml file parser in C++
Why I did:
To compile and link changes done in PR: sonic-net/sonic-swss#3353
How I verify:
Manual Verification