[sai-gen] Update SAI specs to have more p4 meta info #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r12f
approved these changes
Dec 5, 2024
KrisNey-MSFT
pushed a commit
that referenced
this pull request
Dec 11, 2024
Base on #647, refactor the templates of libsai implementation to make it more readable and maintainable. It replaces one single template `saiapi.cpp.j2` with several small templates under directory `SAI/templates/impls`. The changes will not change any generated cpp code for sai api implementation: ``` junhuazhai@junhuazhai-dev-vm:~/workspace/DASH/dash-pipeline$ diff -Nur -x '*.[od]' ~/DASH/dash-pipeline/SAI/lib/ SAI/lib junhuazhai@junhuazhai-dev-vm:~/workspace/DASH/dash-pipeline$ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates p4 meta of sai api to include table keys and action params in detail.
It will be the single truth to generate sai api implementation later.