Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dpapp] add data plane app target #607

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

jimmyzhai
Copy link
Collaborator

@jimmyzhai jimmyzhai commented Jul 23, 2024

Following dpapp HLD - #606, this is the 1st part implementation to add dpapp target in Makefile, which is implemented as a vpp plugin.

@jimmyzhai jimmyzhai force-pushed the dp_app_add_target_dpapp branch from 31e71ac to 45dfe28 Compare July 23, 2024 19:01
@KrisNey-MSFT
Copy link
Collaborator

hi @jimmyzhai - does this need a Reviewer assigned? TY...

@KrisNey-MSFT KrisNey-MSFT requested review from r12f and prsunny July 31, 2024 16:15
@KrisNey-MSFT
Copy link
Collaborator

Hi @prsunny - would you have someone who could review this by chance?

@KrisNey-MSFT
Copy link
Collaborator

@r12f to review

@KrisNey-MSFT
Copy link
Collaborator

hi @r12f - ok to merge this one?

@jimmyzhai jimmyzhai force-pushed the dp_app_add_target_dpapp branch from 88de91b to 56b3974 Compare August 28, 2024 13:24
Copy link
Collaborator

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks Junhua!

dash-pipeline/Makefile Outdated Show resolved Hide resolved
@r12f r12f merged commit a638ad3 into sonic-net:main Aug 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants