-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sai-gen] Add range match type support in SAI generation script. #485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I notice that CI did not get triggered? I would think the rules in https://github.com/sonic-net/DASH/blob/main/.github/workflows/dash-bmv2-ci.yml and the (dpdk version as well) should trigger a CI pipeline, in particular:
- 'dash-pipeline/**'
Without a CI run, one can't tell from the PR if there are any regressions,
yea, this is interesting... Let me check the CI and do another push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks Chris! |
all CI are passed (officially) now. :D |
The range match is frequently used for cases like port ranges and etc.
This change doesn't change anything in the pipeline, but only add the functionality support for future cases.
More can be found in: