Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sai-gen] Add range match type support in SAI generation script. #485

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Dec 13, 2023

The range match is frequently used for cases like port ranges and etc.

This change doesn't change anything in the pipeline, but only add the functionality support for future cases.

More can be found in:

Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I notice that CI did not get triggered? I would think the rules in https://github.com/sonic-net/DASH/blob/main/.github/workflows/dash-bmv2-ci.yml and the (dpdk version as well) should trigger a CI pipeline, in particular:

      - 'dash-pipeline/**'

Without a CI run, one can't tell from the PR if there are any regressions,

@r12f
Copy link
Collaborator Author

r12f commented Dec 14, 2023

yea, this is interesting... Let me check the CI and do another push.

@r12f
Copy link
Collaborator Author

r12f commented Dec 14, 2023

looks like a UI problem. the CI actually ran, but didn't get picked up:

image

Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r12f
Copy link
Collaborator Author

r12f commented Dec 14, 2023

there you go. made a very minor update in the same file, and CI is working now.

image

@r12f
Copy link
Collaborator Author

r12f commented Dec 14, 2023

thanks Chris!

@r12f
Copy link
Collaborator Author

r12f commented Dec 14, 2023

all CI are passed (officially) now. :D

@r12f r12f merged commit 1cff93f into sonic-net:main Dec 14, 2023
4 checks passed
@r12f r12f deleted the user/r12f/range branch December 14, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants