Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sai-gen] Remove unnecessary name annotations in P4 code. #484

Merged
merged 3 commits into from
Dec 13, 2023
Merged

[sai-gen] Remove unnecessary name annotations in P4 code. #484

merged 3 commits into from
Dec 13, 2023

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Dec 13, 2023

Same as previous sai generator changes, no changes on the generated files:

r12f@r12f-dl380:~/data/code/sonic/DASH/dash-pipeline
$ diff SAI/SAI/experimental/ ~/data/code/sonic/DASH-exp/dash-pipeline/SAI/SAI/experimental/
r12f@r12f-dl380:~/data/code/sonic/DASH/dash-pipeline
$ diff SAI/lib/ ~/data/code/sonic/DASH-exp/dash-pipeline/SAI/lib/

@r12f r12f requested a review from kcudnik December 13, 2023 20:19
@r12f
Copy link
Collaborator Author

r12f commented Dec 13, 2023

thanks Kamil!

@r12f r12f merged commit 252c898 into sonic-net:main Dec 13, 2023
4 checks passed
@r12f r12f deleted the user/r12f/name-remove branch December 13, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcudnik kcudnik kcudnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r12f @kcudnik