Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sai-gen] Remove all name-based type guessing heuristics #483

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Dec 13, 2023

After this change, we will have no more type guessing based on object name. Each value size will have a default type. If the default type doesn't match, we shall specify the preferred type in the code.

As all the previous changes, no updates on generated contents:

r12f@r12f-dl380:~/data/code/sonic/DASH/dash-pipeline
$ diff SAI/SAI/experimental/ ~/data/code/sonic/DASH-exp/dash-pipeline/SAI/SAI/experimental/
r12f@r12f-dl380:~/data/code/sonic/DASH/dash-pipeline
$ diff SAI/lib/ ~/data/code/sonic/DASH-exp/dash-pipeline/SAI/lib/

@r12f r12f merged commit 801cecc into sonic-net:main Dec 13, 2023
5 checks passed
@r12f r12f deleted the user/r12f/type-guessing branch December 13, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants