Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sai-gen] Update Sai attribute doc to include the latest support values, also split it into SaiVal and SaiTable for better clarity. #477

Merged
merged 2 commits into from
Dec 11, 2023
Merged

[sai-gen] Update Sai attribute doc to include the latest support values, also split it into SaiVal and SaiTable for better clarity. #477

merged 2 commits into from
Dec 11, 2023

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Dec 11, 2023

No changes to generated contents as below, using the latest main as baseline:

r12f@r12f-dl380:~/data/code/sonic/DASH/dash-pipeline
$ diff SAI/SAI/inc ~/data/code/sonic/DASH-exp/dash-pipeline/SAI/SAI/inc 

r12f@r12f-dl380:~/data/code/sonic/DASH/dash-pipeline
$ diff SAI/SAI/experimental/ ~/data/code/sonic/DASH-exp/dash-pipeline/SAI/SAI/experimental/

r12f@r12f-dl380:~/data/code/sonic/DASH/dash-pipeline
$ diff SAI/lib ~/data/code/sonic/DASH-exp/dash-pipeline/SAI/lib

@r12f
Copy link
Collaborator Author

r12f commented Dec 11, 2023

ok, as promised in #473 . getting the doc and existing code up to date first.

@r12f
Copy link
Collaborator Author

r12f commented Dec 11, 2023

PR is ready to review.

chrispsommers
chrispsommers approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@r12f
Copy link
Collaborator Author

r12f commented Dec 11, 2023

Woot! Thanks!

@r12f r12f mentioned this pull request Dec 11, 2023
Closed
@r12f r12f merged commit b8750ef into sonic-net:main Dec 11, 2023
5 checks passed
@r12f r12f deleted the user/r12f/sai-anno branch December 11, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispsommers chrispsommers chrispsommers approved these changes

@marian-pritsak marian-pritsak Awaiting requested review from marian-pritsak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r12f @chrispsommers