Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups as per #34. #80

Merged
merged 22 commits into from
May 3, 2020
Merged

Cleanups as per #34. #80

merged 22 commits into from
May 3, 2020

Conversation

hyperrealgopher
Copy link
Collaborator

See #34

@someodd
GopherClient: explicit exports, better docs, -crud
14e19dd 
Remove things which aren't used anymore in
GopherClient or are simply outdated.

Use explicit exports in GopherClient for the
module definition.

Drastically improve the documentation in
GopherClient.
@hyperrealgopher hyperrealgopher added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 24, 2020
@hyperrealgopher hyperrealgopher modified the milestones: v1.0.0, v0.1.0 Apr 24, 2020
@hyperrealgopher hyperrealgopher linked an issue Apr 24, 2020 that may be closed by this pull request
Clean up code #34
Open
8 tasks
@hyperrealgopher
Copy link
Collaborator Author

I think my implementation of Data.Text to replace String has made it more memory-hungry.

@hyperrealgopher
Copy link
Collaborator Author

Some of the memory issue might be a viewport problem with scrolling horizontally on menus...

@hyperrealgopher
Copy link
Collaborator Author

hyperrealgopher commented May 1, 2020 •
edited
Loading

Actually, Data.Text switch is great! Less memory hungry by a lot, roughly the same processor intensity. Processor crunching due to <> and un/pack'ing where not necessary. Should cache certain widgets and be careful about those operations/avoiding doing certain things every single update.

tl;dr: <> expensive also cache widgets so not do every time

@hyperrealgopher hyperrealgopher merged commit 86329aa into master May 3, 2020
@hyperrealgopher hyperrealgopher deleted the clean/issue-34-first-clean branch May 3, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

Clean up code
2 participants
@hyperrealgopher @someodd