Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: standardize UI #76

Merged
merged 8 commits into from
Apr 24, 2020
Merged

WIP: standardize UI #76

merged 8 commits into from
Apr 24, 2020

Conversation

hyperrealgopher
Copy link
Collaborator

@hyperrealgopher hyperrealgopher commented Apr 22, 2020 •
edited
Loading

@hyperrealgopher hyperrealgopher added this to the v0.1.0 milestone Apr 22, 2020
@hyperrealgopher hyperrealgopher added the enhancement New feature or request label Apr 22, 2020
@hyperrealgopher
Copy link
Collaborator Author

hyperrealgopher commented Apr 23, 2020 •
edited
Loading

apparently this broke scrolling.

@hyperrealgopher
Copy link
Collaborator Author

hyperrealgopher commented Apr 23, 2020 •
edited
Loading

I actually don't need to use a ton of different viewports, i just need to reset the viewport position every time a new page. i can also keep viewport positions by location as per #77. Also, you could even save the history of viewport positions?

@hyperrealgopher hyperrealgopher added the bug Something isn't working label Apr 23, 2020
@hyperrealgopher hyperrealgopher linked an issue Apr 23, 2020 that may be closed by this pull request
remember line # when going through history (viewport thing) #77
Open
@hyperrealgopher hyperrealgopher removed a link to an issue Apr 23, 2020
remember line # when going through history (viewport thing) #77
Open
@someodd
WIP: fix viewport bug
c04b8e1 
This is buggy because I should have a different event for signifying
that we're done with displaying the progress and now we're going to
switch to a new mode... I guess? I don't know... maybe just a flag
in the state... I'm not sure how to tackle this. The problem is right
now the modeTransition function gets executed every update to the state
via NewState event which gets updated to show progress in downloading bytes
until the final state which is the new page (also sent via NewState event).
@someodd
Add final event, to reset viewport between
33ec36a
@someodd
Fix --pedantic errors
44911a4
@hyperrealgopher hyperrealgopher merged commit e792aed into master Apr 24, 2020
@hyperrealgopher hyperrealgopher deleted the feature/standardize-ui branch April 24, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hyperrealgopher @someodd