Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pointer: Replace old primitives with createPointers #697

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thetarnav
Copy link
Member

It's probably a good time to remove that crap that was the pointer package and replace it with a simple, but actually useful primitive.
The old api was just an experimentation that ended up too complicated and not at at useful. The package is not used much either judging by the downloads.
The new createPointers primitive is simple, but it something I would use, it just gives you a list of pointer events of pointers that are currently on the screen. All the other magic like position_to_element, is_inside and is_down can be derived from this list, and I'll be adding examples how to do that to the readme later.

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: ac782dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,4 +1,4 @@
import { createPointerListeners, pointerHover, createPointerList } from "../src/index.js";
import { createPointerListeners, pointerHover, createPointerList } from "../src/index-ols.js";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file does not exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven’t touched demo yet
well I did
but by mistake
it’s wip :)

);
if (onGotCapture) addEventListener("gotpointercapture", onGotCapture);
if (onLostCapture) addEventListener("lostpointercapture", onLostCapture);
function upsert_pointer(pointers: PointerEvent[], e: PointerEvent): PointerEvent[] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "upsert" mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update/insert
it’s such a cool shortcut I’m upsert I don’t see it more :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just use "set"?

const up_event_touch = new PointerEvent("pointerup", { pointerId: 2, pointerType: "touch" });
const cancel_event_touch = new PointerEvent("pointercancel", { pointerId: 2, pointerType: "touch" });

const ref = document.createElement("div");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same ref for all tests seem a bit brittle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants