Added support for building multi-arch Docker images for elasticmq-native #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adamw
reviewed
May 31, 2021
build.sbt
Outdated
| @@ -283,6 +287,14 @@ lazy val nativeServer: Project = (project in file("native-server")) | |||
| dockerEntrypoint := Seq("/sbin/tini", "--", "/opt/docker/bin/elasticmq-native-server", "-Dconfig.file=/opt/elasticmq.conf"), | |||
| dockerUpdateLatest := true, | |||
| dockerExposedPorts := Seq(9324,9325), | |||
| dockerBuildOptions := dockerBuildOptions.value :+ "--platform=linux/arm64,linux/amd64" :+ "--push", | |||
| dockerBuildCommand := { | |||
There was a problem hiding this comment.
maybe this can be part of dockerBuildxSettings and hence not repeated?
adamw
reviewed
May 31, 2021
| @@ -349,7 +364,7 @@ lazy val uiSettings = Seq( | |||
| lazy val dockerBuildxSettings = Seq( | |||
| createBuildx := { | |||
| streams.value.log("Creating docker buildx instance") | |||
| haltOnCmdResultError(Process("docker buildx create --use --name multi-arch-builder", baseDirectory.value).!) | |||
| Process("docker buildx create --use --name multi-arch-builder", baseDirectory.value).! | |||
There was a problem hiding this comment.
Well, that command will return either success with new Buildx instance or just info about existing instance.
There was a problem hiding this comment.
So if the instance exist, the command ends in error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.