release: v24.0.4

software-challenge · Aug 11, 2023 · c0a135d · c0a135d
1 parent d12a21b
commit c0a135d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -1,4 +1,4 @@
 socha.gameName=penguins
 socha.version.year=24
 socha.version.minor=00
-socha.version.patch=03
+socha.version.patch=04
diff --git a/gradle/build.gradle.kts b/gradle/build.gradle.kts
@@ -35,7 +35,7 @@ val javaTargetVersion = JavaVersion.VERSION_1_8
 val javaVersion = JavaVersion.current()
 println("Current version: $version (Beta: $isBeta) Game: $game (Java Version: $javaVersion)")
 if (javaVersion != javaTargetVersion)
-    System.err.println("Java version $javaTargetVersion is recommended - expect issues with generating documentation (consider using '-x doc' if you don't care)")
+    System.err.println("Java version $javaTargetVersion is recommended - expect issues with generating documentation (consider '-x doc' if you don't care)")
 
 val doAfterEvaluate = ArrayList<(Project) -> Unit>()
 tasks {

diff --git a/plugin/src/test/kotlin/sc/plugin2024/GameStateTest.kt b/plugin/src/test/kotlin/sc/plugin2024/GameStateTest.kt
@@ -123,7 +123,7 @@ class GameStateTest: FunSpec({
             ship.movement = 3
             gameState.checkAdvanceLimit(ship).run {
                 distance shouldBe 1
-                costUntil(1) shouldBe 3
+                costUntil(1) shouldBe 2
                 problem shouldBe AdvanceProblem.SHIP_ALREADY_IN_TARGET
             }
         }
@@ -163,7 +163,6 @@ class GameStateTest: FunSpec({
         }
         test("pushing and current") {
             gameState.otherShip.position = CubeCoordinates.ORIGIN + CubeDirection.LEFT.vector
-            gameState.getSensibleMoves() shouldNotContain Move(Acceleration(1), Turn(CubeDirection.DOWN_RIGHT), Advance(1), Push(CubeDirection.DOWN_LEFT))
             gameState.getSensibleMoves() shouldContain Move(Acceleration(2), Turn(CubeDirection.DOWN_RIGHT), Advance(1), Push(CubeDirection.DOWN_LEFT))
 
             ship.freeTurns = 0

diff --git a/server/src/test/java/sc/server/network/ClientXmlReadTest.java b/server/src/test/java/sc/server/network/ClientXmlReadTest.java
@@ -48,7 +48,7 @@ public void clientSendPacketTest() throws IOException {
 
     client.start();
     client.send(new ExamplePacket());
-    stringInterface.close();
+    // TODO this attempts to close a closed stream: client.close();
     String data = stringInterface.readData();
     assertEquals("<protocol>\n  <example/>", data);
   }