Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sub-processing of ‘MERGE INTO’ #321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix sub-processing of ‘MERGE INTO’ #321

wants to merge 1 commit into from
+5 −4

Conversation

luciengaitskell
Copy link

@luciengaitskell luciengaitskell commented Jul 20, 2022 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-638839: MERGE INTO does not render argument correctly #322

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Fix sub-processing of MERGE INTO compiler.

@sfc-gh-mkeller
Copy link
Collaborator

Hi @luciengaitskell it looks like you missed this part of the issue template:

Make sure that there is an accompanying issue to your PR.

Please create an issue and describe the problem itself before fixing it

Thanks!

@luciengaitskell luciengaitskell mentioned this pull request Jul 21, 2022
Closed
@luciengaitskell
Copy link
Author

luciengaitskell commented Jul 21, 2022 •
edited
Loading

Please create an issue and describe the problem itself before fixing it

I have now created issue #322

@luciengaitskell
Copy link
Author

@sfc-gh-mkeller Am I missing any remaining steps for the review process?
Thanks in advance.

@luciengaitskell
Copy link
Author

Just to bump this- Is there a chance of having this PR reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller Awaiting requested review from sfc-gh-mkeller

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-638839: MERGE INTO does not render argument correctly
2 participants
@luciengaitskell @sfc-gh-mkeller