415 issue complete the funcionality of value schema file serializer #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
RobertoSngular
assigned RobertoSngular, GraciMndzSNG, pablorodriguez-sngular and jemacineiras and unassigned ivangsa, pablorodriguez-sngular, RobertoSngular and GraciMndzSNG
|
This pull request hasn't been labeled as |
RobertoSngular
assigned pablorodriguez-sngular, RobertoSngular and GraciMndzSNG and unassigned jemacineiras
…ue-schema-file-serializer # Conflicts: # src/main/java/com/sngular/kloadgen/config/schemaregistry/SchemaRegistryConfigElementBeanInfo.java # src/main/java/com/sngular/kloadgen/extractor/SchemaExtractor.java # src/main/java/com/sngular/kloadgen/extractor/extractors/ExtractorFactory.java # src/main/java/com/sngular/kloadgen/extractor/extractors/avro/AvroExtractor.java # src/main/java/com/sngular/kloadgen/extractor/extractors/json/AbstractJsonExtractor.java # src/main/java/com/sngular/kloadgen/extractor/extractors/json/JsonDefaultExtractor.java # src/main/java/com/sngular/kloadgen/extractor/extractors/json/JsonExtractor.java # src/main/java/com/sngular/kloadgen/extractor/extractors/protobuff/ProtobuffExtractor.java # src/main/java/com/sngular/kloadgen/loadgen/impl/ProtobufLoadGenerator.java # src/main/java/com/sngular/kloadgen/processor/objectcreatorfactory/impl/JsonObjectCreatorFactory.java # src/main/java/com/sngular/kloadgen/processor/util/SchemaProcessorUtils.java # src/main/java/com/sngular/kloadgen/property/editor/FileSubjectPropertyEditor.java # src/main/java/com/sngular/kloadgen/property/editor/KeyDeserializerPropertyEditor.java # src/main/java/com/sngular/kloadgen/property/editor/SchemaRegistryConfigPropertyEditor.java # src/main/java/com/sngular/kloadgen/property/editor/SerDesPackageValue.java # src/main/java/com/sngular/kloadgen/randomtool/generator/ProtoBufGeneratorTool.java # src/main/java/com/sngular/kloadgen/schemaregistry/SchemaRegistryConstants.java # src/main/java/com/sngular/kloadgen/schemaregistry/SchemaRegistryManagerFactory.java # src/main/java/com/sngular/kloadgen/schemaregistry/adapter/impl/AbstractParsedSchemaAdapter.java # src/main/java/com/sngular/kloadgen/schemaregistry/adapter/impl/ApicurioSchemaMetadata.java # src/main/java/com/sngular/kloadgen/schemaregistry/adapter/impl/BaseSchemaMetadata.java # src/main/java/com/sngular/kloadgen/schemaregistry/adapter/impl/ConfluentAbstractParsedSchemaMetadata.java # src/main/java/com/sngular/kloadgen/schemaregistry/adapter/impl/GenericSchemaRegistryAdapter.java # src/main/java/com/sngular/kloadgen/schemaregistry/impl/ApicurioSchemaRegistry.java # src/main/java/com/sngular/kloadgen/schemaregistry/impl/ConfluentSchemaRegistry.java # src/main/java/com/sngular/kloadgen/serializer/AvroDeserializer.java # src/test/java/com/sngular/kloadgen/config/valuefileserialized/ValueFileSerializedConfigElementBeanInfoTest.java # src/test/java/com/sngular/kloadgen/config/valueserialized/ValueSerializedConfigElementBeanInfoTest.java # src/test/java/com/sngular/kloadgen/extractor/SchemaExtractorTest.java
jemacineiras
reviewed
Nov 3, 2023
| final SchemaRegistryEnum schemaRegistryEnum = SchemaRegistryEnum.valueOf(registryName.toUpperCase()); | ||
|
|
||
| final Object schema; |
There was a problem hiding this comment.
Why you want to go back with this change?
|
|
||
| public interface ExtractorRegistry<T> { | ||
| List<FieldValueMapping> processSchema(final T schema, SchemaRegistryEnum registry); | ||
|
|
||
| ParsedSchema processSchema(final String fileContent); |
There was a problem hiding this comment.
We should not add confluent dependencies here.
|
|
||
| public class AvroExtractor implements ExtractorRegistry<Object> { | ||
|
|
||
| private static Map<SchemaRegistryEnum, Extractor> schemaRegistryMap = Map.of(SchemaRegistryEnum.CONFLUENT, new AvroConfluentExtractor(), SchemaRegistryEnum.APICURIO, | ||
| new AvroApicurioExtractor()); | ||
| static final Map<SchemaRegistryEnum, Extractor> SCHEMA_REGISTRY_MAP = Map.of(SchemaRegistryEnum.CONFLUENT, new AvroConfluentExtractor(), SchemaRegistryEnum.APICURIO, |
There was a problem hiding this comment.
why change the visibility?
| @@ -23,10 +23,10 @@ | |||
|
|
|||
| public abstract class AbstractJsonExtractor { | |||
|
|
|||
| private final JSONSchemaParser jsonSchemaParser = new JSONSchemaParser(); | |||
| public static final JSONSchemaParser JSON_SCHEMA_PARSER = new JSONSchemaParser(); | |||
| @@ -182,6 +175,46 @@ public final void actionPerformed(final ActionEvent event) { | |||
| } | |||
| } | |||
|
|
|||
| public final void buildTable(final List<FieldValueMapping> attributeList) { | |||
There was a problem hiding this comment.
Not sure about this...
| @@ -100,7 +100,7 @@ private Object getEnumOrGenerate(final String fieldName, final String fieldType, | |||
| final List<String> enumValueList = schema.getEnumSymbols(); | |||
| value = new GenericData.EnumSymbol(schema, enumValueList.get(RandomUtils.nextInt(0, enumValueList.size()))); | |||
| } else { | |||
| if ("Seq".equalsIgnoreCase(fieldType)) { | |||
| if ("Seq".equalsIgnoreCase(fieldType)) { // Este if nunca da true, no se si sobra o está mal | |||
There was a problem hiding this comment.
English please. Check documentation.
jemacineiras
added
bug
jemacineiras
approved these changes
Nov 6, 2023
RobertoSngular
deleted the
415-issue-complete-the-funcionality-of-value-schema-file-serializer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.