Skip to content

Commit

Permalink
set cleanup_data_sources to False by default; use easyblock_type
Browse files Browse the repository at this point in the history
  • Loading branch information
Samuel Moors committed Mar 17, 2024
1 parent 9dd8e39 commit 63bb474
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions easybuild/easyblocks/generic/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ def extra_options(extra_vars=None):
"""Extra easyconfig parameters specific to Data easyblock."""
extra_vars = EasyBlock.extra_options(extra_vars)
extra_vars.update({
'extract_sources': [True, "Whether or not to extract sources", CUSTOM],
'extract_sources': [True, "Whether or not to extract data sources", CUSTOM],
'data_install_path': [None, "Custom installation path for datasets", CUSTOM],
'cleanup_sources': [True, "Whether or not to delete the sources after installation", CUSTOM]
'cleanup_data_sources': [False, "Whether or not to delete the data sources after installation", CUSTOM]
})
return extra_vars

def __init__(self, *args, **kwargs):
"""Initialize Dataset-specific variables."""
self.is_data = True
self.easyblock_type = 'data'
super(Dataset, self).__init__(*args, **kwargs)

if self.cfg['data_install_path']:
Expand All @@ -66,6 +66,6 @@ def cleanup_step(self):
"""Cleanup sources after installation"""
if self.cfg['cleanup_sources']:
for src in self.src:
self.log.info("Removing source %s" % src['name'])
self.log.info("Removing data source %s" % src['name'])
remove_file(src['path'])
super(Dataset, self).cleanup_step()

0 comments on commit 63bb474

Please sign in to comment.