Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce false positives of ShouldHaveUsedTimestampValidator #2480

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Reduce false positives of ShouldHaveUsedTimestampValidator #2480

merged 2 commits into from
Dec 10, 2024

Conversation

rchache
Copy link
Contributor

@rchache rchache commented Nov 27, 2024 •
edited
Loading

Background

  • Reduce false positives of ShouldHaveUsedTimestampValidator, when a member shape targets a list of Timestamps or structure of solely Timestamps
  • Also allows timey members to target enums without emitting events
  • Improves the CX by reducing unhelpful noise in smithy validator

Testing

  • added new unit tests

Links

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchache rchache requested a review from a team as a code owner November 27, 2024 18:56
@rchache rchache requested a review from sugmanue November 27, 2024 18:56
@hpmellema hpmellema merged commit b855e2b into smithy-lang:main Dec 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpmellema hpmellema hpmellema approved these changes

@sugmanue sugmanue Awaiting requested review from sugmanue sugmanue is a code owner automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchache @hpmellema