Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REL: Remove bad_request Changeset Fn Clause #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

REL: Remove bad_request Changeset Fn Clause #128

wants to merge 1 commit into from

Conversation

jwdotjs
Copy link
Contributor

@jwdotjs jwdotjs commented Mar 31, 2023

This is more or less a breaking change for places that have bad_request/2 implemented. I'm unsure if this should be a major version bump?

jollyjerr
jollyjerr approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@jollyjerr jollyjerr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a major version bump

https://xkcd.com/1172/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jollyjerr jollyjerr jollyjerr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwdotjs @jollyjerr