Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed API method for eth-beacon #3252

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Changed API method for eth-beacon #3252

merged 5 commits into from
Jul 15, 2024

Conversation

karen-stepanyan
Copy link
Collaborator

@karen-stepanyan karen-stepanyan commented Apr 2, 2024

DF-19699

Updated eth-beacon balance transport to use POST method instead of GET when querying balances of addresses.

Functional tests were performed as well

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 9c2cd73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chainlink/eth-beacon-adapter Major
@chainlink/proof-of-reserves-adapter Patch
@chainlink/renvm-address-set-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

alecgard
alecgard previously approved these changes Apr 25, 2024
.changeset/giant-avocados-cover.md Outdated Show resolved Hide resolved
alecgard
alecgard previously approved these changes May 17, 2024
mmcallister-cll
mmcallister-cll approved these changes Jul 13, 2024
Copy link
Contributor

@mmcallister-cll mmcallister-cll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explicitly mention v2.5.0 Beacon API in the changeset and README. Otherwise LGTM!

@mmcallister-cll
Copy link
Contributor

OK to merge this despite EA framework check failure -- new EA framework version just went in (should be addressed in a PR that updates all ea-framework versions)

@karen-stepanyan karen-stepanyan merged commit 732cf4c into main Jul 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants