Support custom labels #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @slok, would you take a look at this PR please? |
|
Thanks for the PR, sorry I missed this one. I don't know if we want to implement this in the library as today, dynamic labels are tricky and could have undesired side effects. For now, I would like to park this feature and think a bit more. Also, we have this other PR #74 that implements a similar feature. |
|
This PR was opened before #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @slok,
I've added custom labels support for my project and now I see that this may be the solution for #47. Also did tiny tests cleanup during my work.
Custom labels are supported for prometheus as this is the collector I personally use. However, new functionality does not break previous implementation of Recorder and anyone can add custom labels support for any existing recorder.
FastHTTP example is also provided.
Hope this PR help someone.