Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native histogram exposition for Prometheus #218

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jaredjenkins
Copy link

This patch adds optional native histogram support for the two histograms currently offered in this library.

@jaredjenkins jaredjenkins requested a review from slok as a code owner April 17, 2024 14:14
@slok
Copy link
Owner

slok commented Apr 19, 2024

This is an awesome feature! many thanks, however I'm not sure about adding this directly to the Prometheus metrics backend currently used, what do you think if we make a new prometheus native histograms backend and once native histograms are stable, we think how to merge/promote to the prometheus default backend? This package could be called something like prometheus_native_histograms or similar.

@jaredjenkins
Copy link
Author

This is an awesome feature! many thanks, however I'm not sure about adding this directly to the Prometheus metrics backend currently used, what do you think if we make a new prometheus native histograms backend and once native histograms are stable, we think how to merge/promote to the prometheus default backend? This package could be called something like prometheus_native_histograms or similar.

@slok I'm not sure the extra implementation is worth it given that Native Histograms will GA this year and the schema is pretty well established at this point. Prometheus needs to maintain compatibility with the Exponential Histograms in OpenTelemetry and the protos are fairly similar in terms of what they cover. This change is a no-op unless folks decide to use native histograms, too. If you set a bucket factor of < 1, it won't be exposed as a native histogram. And, Prometheus will be offering the ability to scrape both classic and native so that people can migrate over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants