Make glfw.Window.Hints.set public

[terraquad]

I would like to use it to add Graphics API specific hints to my default hints:

const defaultHints = .{
    .visible = false,
    .resizable = false,
};
const graphicsApiHints = .{
    .opengl_profile = .opengl_core_profile,
    .context_version_major = 3,
    .context_version_minor = 3,
    .opengl_forward_compat = true,
}
defaultHints.set(); // would like to do this
graphicsApiHints.set(); // would like to do this
// Create window...

Current output:

src/App.zig:17:36: error: 'set' is not marked 'pub'
    rendering_backend.windowHints().set();
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
/home/tq/.cache/zig/p/122055be80f617e5a3b64bce8ad4dd0fcd8635ece0ae48c86f3bc9dd05e1ba6302fd/src/Window.zig:252:5: note: declared here
    fn set(hints: Hints) void {
    ^~~~~~~~~~~~~~~~~~~~~~~~~

• By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

[slimsag]

you shouldn't be calling set() directly, the API is designed so that you pass hints to glfw.Window.create()

[terraquad]

I know, but there is no way to combine structs so I want to add them separately.

In this case, I can't combine defaultHints and graphicsApiHints into one to pass it to glfw.Window.create, so I tried to call defaultHints.set and then graphicsApiHints.set.

[terraquad]

I could also add a doc comment that discourages the use of Hints.set and to instead use glfw.Window.create whenever possible.

[slimsag]

sorry, but I don't understand the use case and don't currently think this is a good change.