Add #6 Add hall of fame #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ThulinaWickramasinghe
commented
Aug 17, 2024
ThulinaWickramasinghe
commented
- Add routing for hall-of-fame
- WIP dynamic data fetching for hof
ThulinaWickramasinghe
changed the title
Closed
Akalanka47000
requested changes
Aug 19, 2024
Akalanka47000
requested changes
Aug 20, 2024
src/components/layout/header.jsx
Outdated
| const { pathname } = useLocation(); | ||
|
|
||
| useEffect(() => { | ||
| setIsHallOfFame(pathname === hallOfFame); |
There was a problem hiding this comment.
We don't need this extra state, this comparison can be moved directly to line 79
There was a problem hiding this comment.
This is being used in 2 places. Will add to a variable and use it.
There was a problem hiding this comment.
Done
Akalanka47000
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.