Revert "S3 CRT Client" #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6093173.
|
OpenAI failed to generate a review: This model's maximum context length is 16385 tokens. However, your messages resulted in 22915 tokens. Please reduce the length of the messages. |
vthacker
approved these changes
Jul 14, 2023
|
See awslabs/aws-c-http#413 for root cause, #610 for a detailed explanation of the issue as well as attempted workarounds. |
bryanlb
added a commit
that referenced
this pull request
Jul 14, 2023
Merged
bryanlb
added a commit
that referenced
this pull request
Jul 27, 2023
bryanlb
added a commit
that referenced
this pull request
Sep 12, 2023
bryanlb
added a commit
that referenced
this pull request
Sep 12, 2023
* Revert "Revert "S3 CRT Client (#598)" (#609)" This reverts commit 6728de8. * Add option for providing AWS S3 crt proxy as system properties --------- Co-authored-by: Bryan Burkholder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily reverting, as this client appears to not respect the no_proxy env variable.