Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Rework KEN embeddings example #682

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

DOC Rework KEN embeddings example #682

wants to merge 7 commits into from

Conversation

LilianBoulard
Copy link
Member

Extracted from #546.

@LilianBoulard LilianBoulard self-assigned this Jul 31, 2023
@LilianBoulard LilianBoulard added documentation Add or improve the documentation no changelog needed labels Jul 31, 2023
jovan-stojanovic
jovan-stojanovic requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@jovan-stojanovic jovan-stojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few small changes and this is good for me.

examples/06_ken_embeddings.py Outdated Show resolved Hide resolved
examples/06_ken_embeddings.py Outdated Show resolved Hide resolved
examples/06_ken_embeddings.py Outdated Show resolved Hide resolved
examples/06_ken_embeddings.py Outdated Show resolved Hide resolved
examples/06_ken_embeddings.py Outdated Show resolved Hide resolved
examples/06_ken_embeddings.py Outdated Show resolved Hide resolved
@jovan-stojanovic
Copy link
Member

jovan-stojanovic commented Sep 11, 2023 •
edited
Loading

Thanks @LilianBoulard! As agreed, I will take over this PR so we move faster.

@jovan-stojanovic jovan-stojanovic changed the base branch from main to 0.4.X September 11, 2023 12:12
@jovan-stojanovic jovan-stojanovic changed the base branch from 0.4.X to main September 11, 2023 12:12
@jovan-stojanovic jovan-stojanovic changed the title Rework KEN embeddings example DOC Rework KEN embeddings example Sep 12, 2023
@jovan-stojanovic jovan-stojanovic self-assigned this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovan-stojanovic jovan-stojanovic jovan-stojanovic requested changes

@Vincent-Maladiere Vincent-Maladiere Awaiting requested review from Vincent-Maladiere

@GaelVaroquaux GaelVaroquaux Awaiting requested review from GaelVaroquaux

Requested changes must be addressed to merge this pull request.

Assignees

@LilianBoulard LilianBoulard

@jovan-stojanovic jovan-stojanovic

Labels
documentation Add or improve the documentation no changelog needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LilianBoulard @jovan-stojanovic