Put all GPIO defines in gpio_bitaxe.h #566
Open
+56
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutatrum
commented
Dec 8, 2024
| .channel = LEDC_CHANNEL_3, | ||
| .timer_sel = LEDC_TIMER_0, | ||
| .intr_type = LEDC_INTR_DISABLE, | ||
| .gpio_num = 38, // Define the output GPIO |
There was a problem hiding this comment.
Pins 38, 39 and 40 were not configured, so I figured this file was both unused and broken.
|
Better suggestion for the filename are welcome. Naming things is still one of the hardest problems in CS. |
WantClue
added
enhancement
WantClue
approved these changes
Dec 10, 2024
|
please resolve conflicts |
|
Conflicts resolved |
WantClue
approved these changes
Dec 12, 2024
eandersson
reviewed
Dec 13, 2024
| @@ -0,0 +1,11 @@ | |||
| #ifndef GPIO_BITAXE_H_ | |||
There was a problem hiding this comment.
My only comment is that it feels backwards that components would depend on a header in the app (main).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #547